[DOCS] Add new documentation checks to align with other OEP repositories#691
Conversation
2cf9520 to
98a68ad
Compare
d02fdc9 to
b005d76
Compare
f6a5eb1 to
ff4949c
Compare
ff4949c to
edd6dd4
Compare
Signed-off-by: Sebastian Golebiewski <sebastianx.golebiewski@intel.com>
edd6dd4 to
68b9d76
Compare
Signed-off-by: Sebastian Golebiewski <sebastianx.golebiewski@intel.com>
oonyshch
left a comment
There was a problem hiding this comment.
Overall the approach looks good, please consider comments.
| DOCS_DIR: ${{ inputs.docs_directory }} | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 |
There was a problem hiding this comment.
Please check whether this version v6.0.2 is right
| shell: bash | ||
| run: | | ||
| cd "${GITHUB_WORKSPACE}/${DOCS_DIR}" | ||
| wget https://docs.openedgeplatform.intel.com/template/template.tar.gz |
There was a problem hiding this comment.
Please consider adding error handling and checksum verification for the downloaded tarball:
| wget https://docs.openedgeplatform.intel.com/template/template.tar.gz | |
| wget -q --show-progress https://docs.openedgeplatform.intel.com/template/template.tar.gz || { echo "Failed to download template"; exit 1; } | |
| # Verify checksum if available | |
| # sha256sum -c template.tar.gz.sha256 |
Co-authored-by: Olena (Lena) Onyshchenko <olena.onyshchenko@intel.com>
nszczygl9
left a comment
There was a problem hiding this comment.
Do we need to separate documentation workflows into 2 files?
I think we can have one documentation-check.yaml and just add steps from docs-reusable-workflow.yaml in build-dlstreamer-documentation job.
| filter: | ||
| permissions: | ||
| contents: read # needed for actions/checkout | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
please change runner group to dlstreamer
| persist-credentials: false | ||
| - name: Set paths filter | ||
| id: filter | ||
| uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 |
There was a problem hiding this comment.
please update version to v4.0.1 and add comment with this version:
uses: dorny/paths-filter@fbd0ab8 #v4.0.1
Description
Add new documentation checks to GH to align with other repositiories in Open Edge Platform.
Fixes # (issue)
Any Newly Introduced Dependencies
Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: