Skip to content

[DOCS] Add new documentation checks to align with other OEP repositories#691

Open
sgolebiewski-intel wants to merge 3 commits intoopen-edge-platform:mainfrom
sgolebiewski-intel:add-documentation-checks-for-main
Open

[DOCS] Add new documentation checks to align with other OEP repositories#691
sgolebiewski-intel wants to merge 3 commits intoopen-edge-platform:mainfrom
sgolebiewski-intel:add-documentation-checks-for-main

Conversation

@sgolebiewski-intel
Copy link
Contributor

@sgolebiewski-intel sgolebiewski-intel commented Mar 12, 2026

Description

Add new documentation checks to GH to align with other repositiories in Open Edge Platform.

Fixes # (issue)

Any Newly Introduced Dependencies

Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I agree to use the MIT license for my code changes.
  • I have not introduced any 3rd party components incompatible with MIT.
  • I have not included any company confidential information, trade secret, password or security token.
  • I have performed a self-review of my code.

@sgolebiewski-intel sgolebiewski-intel force-pushed the add-documentation-checks-for-main branch 2 times, most recently from d02fdc9 to b005d76 Compare March 12, 2026 14:31
@sgolebiewski-intel sgolebiewski-intel requested a review from a team as a code owner March 12, 2026 14:34
@sgolebiewski-intel sgolebiewski-intel force-pushed the add-documentation-checks-for-main branch 3 times, most recently from f6a5eb1 to ff4949c Compare March 13, 2026 06:53
@kblaszczak-intel kblaszczak-intel marked this pull request as draft March 13, 2026 09:30
@sgolebiewski-intel sgolebiewski-intel force-pushed the add-documentation-checks-for-main branch from ff4949c to edd6dd4 Compare March 24, 2026 12:27
Signed-off-by: Sebastian Golebiewski <sebastianx.golebiewski@intel.com>
@sgolebiewski-intel sgolebiewski-intel force-pushed the add-documentation-checks-for-main branch from edd6dd4 to 68b9d76 Compare March 24, 2026 12:30
@sgolebiewski-intel sgolebiewski-intel marked this pull request as ready for review March 24, 2026 12:30
Signed-off-by: Sebastian Golebiewski <sebastianx.golebiewski@intel.com>
Copy link
Contributor

@oonyshch oonyshch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the approach looks good, please consider comments.

DOCS_DIR: ${{ inputs.docs_directory }}
steps:
- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check whether this version v6.0.2 is right

shell: bash
run: |
cd "${GITHUB_WORKSPACE}/${DOCS_DIR}"
wget https://docs.openedgeplatform.intel.com/template/template.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding error handling and checksum verification for the downloaded tarball:

Suggested change
wget https://docs.openedgeplatform.intel.com/template/template.tar.gz
wget -q --show-progress https://docs.openedgeplatform.intel.com/template/template.tar.gz || { echo "Failed to download template"; exit 1; }
# Verify checksum if available
# sha256sum -c template.tar.gz.sha256

Co-authored-by: Olena (Lena) Onyshchenko <olena.onyshchenko@intel.com>
Copy link
Contributor

@nszczygl9 nszczygl9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to separate documentation workflows into 2 files?
I think we can have one documentation-check.yaml and just add steps from docs-reusable-workflow.yaml in build-dlstreamer-documentation job.

filter:
permissions:
contents: read # needed for actions/checkout
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change runner group to dlstreamer

persist-credentials: false
- name: Set paths filter
id: filter
uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update version to v4.0.1 and add comment with this version:
uses: dorny/paths-filter@fbd0ab8 #v4.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants